Pin LLVM versions in github actions #619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the merge of 624 this is less of an issue now that support for LLVM 11 has been merged in. The remaining failure is a legitimate behavior change in LLVM 11 that I should be able to address in #618. |
|
Good to know! It still seems like a good idea to make sure that we know what version of clang we're using. The fact that it worked for so long is a matter of luck more than anything else, and I'd prefer to save my luck for other things :) |
|
In 618, the clang version is detected and reported as part of the test output. |
|
I think this is superseded by #753. Feel free to reopen if I'm mistaken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent our builds from failing if LLVM changes underneath as previously we were relying on the first LLVM to be found on the path, which can change without warning.